mxqsub: Implement --tmpdir argument without units #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The usage string of mxqsub says, that any size can be given without units, in which case Mebibytes is assumed. This doesn't currently work for --tmpdir, because the function mx_strtobytes which is used to convert the string, doesn't accept numbers without units. Try mx_strtou64() first to process numerical argments without a unit. Because tmpdir size is stored in Gibibytes and not Mebibytes internally, the value needs to be divided by 1024.
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The usage string of mxqsub says, that any size can be given without units, in which case Mebibytes is assumed.
This doesn't currently work for --tmpdir, because the function mx_strtobytes which is used to convert the string, doesn't accept numbers without units.
Try mx_strtou64() first to process numerical argments without a unit. Because tmpdir size is stored in Gibibytes and not Mebibytes internally, the value needs to be divided by 1024.